search

rapidsai / rapids.ai

rapids.ai web site
https://rapids.ai
8 stars 17 forks source link

Fix devcontainer #393

Open bdice opened 3 weeks ago

bdice commented 3 weeks ago

This PR fixes the devcontainer, which was erroring when failing to find npm. I believe this is because the Node feature had feature "none" instead of "latest". I also made the get_medium.py script executable.

ajschmidt8 commented 3 weeks ago

hold on. the "none" was intentional because nvm should read the Node version from https://github.com/rapidsai/rapids.ai/blob/main/.nvmrc during the init script:

Is that not what was happening?

The .nvmrc file is used by Netlify as well (see below). It's a single source of truth.

bdice commented 3 weeks ago

I think the devcontainer init script failed to find npm. I will try to reproduce.

bdice commented 3 weeks ago

Failure looks like this:

./scripts/devcontainer-init.sh: line 29: npm: command not found

There's no other helpful context. It gets through the hugo config command and then I assume it's failing because Node isn't installed.