rapidsai / rmm

RAPIDS Memory Manager
https://docs.rapids.ai/api/rmm/stable/
Apache License 2.0
480 stars 195 forks source link

[FEA] Disable doxygen documentation publication #1372

Closed vyasr closed 6 months ago

vyasr commented 11 months ago

Is your feature request related to a problem? Please describe. After #1324 the C++ APIs of rmm are documented within the Sphinx documentation along with the Python APIs. As a result, there is no longer a need for publication of the doxygen docs. However, they were left in place to allow easy comparison during the remainder of the 23.12 development cycle.

Describe the solution you'd like We should stop publishing the doxygen docs before the release.

ajschmidt8 commented 11 months ago

Linking this comment in particular that identify the necessary follow-up tasks

https://github.com/rapidsai/rmm/pull/1324#pullrequestreview-1710741054

harrism commented 8 months ago

Hope you don't mind, I'm assigning you @ajschmidt8 and @vyasr. Do you think it's reasonable to finish this in 24.02? We can push to 24.04 if not.

vyasr commented 8 months ago

Yup assigning us is fine. We've already stopped building the doxygen HTML, so I think we should be good to go for this release. Perhaps a website update is still needed though, @ajschmidt8 should I modify https://github.com/rapidsai/docs/pull/464 to just remove rmm and get that merged, then come back to cudf when we remove it?

harrism commented 7 months ago

@ajschmidt8 @vyasr is this going to happen in 24.04 or should I move to 24.06?

ajschmidt8 commented 6 months ago

As far as I can tell, this was completed in the PRs below:

@vyasr, any remaining items here? or can we close it? I think that should be everything.

ajschmidt8 commented 6 months ago

Confirmed with Vyas offline that it is complete. Closing.