ensure update-version.sh preserves alpha specs - Githubissues

rapidsai / rmm

RAPIDS Memory Manager

https://docs.rapids.ai/api/rmm/stable/

Apache License 2.0

446 stars 188 forks source link

ensure update-version.sh preserves alpha specs #1572

Closed jameslamb closed 1 month ago

jameslamb commented 1 month ago

Description

Contributes to https://github.com/rapidsai/build-planning/issues/31

Follow-up to #1502

ensures that update-version.sh does not remove alpha specs like ,>=0.0.0a0 in pyproject.toml and conda environment files
consolidates rapids-build-backend versions in dependencies.yaml
- since I was pushing a new commit here anyway, figured I'd take the opportunity to include that simplification recommended in https://github.com/rapidsai/cudf/pull/15245#discussion_r1617724287

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.

Notes for Reviewers

Shouldn't this also be adding a test on the `__git_commit` and `version__` constants?

I'd said previously that I didn't include that in #1502, but looks like I actually did:

https://github.com/rapidsai/rmm/blob/15c04666e20712f30882a903bfad79e208d8e852/python/rmm/rmm/tests/test_version.py#L18

jameslamb commented 1 month ago

/merge