Update Thrust CMake Guide link in README.md - Githubissues

rapidsai / rmm

RAPIDS Memory Manager

https://docs.rapids.ai/api/rmm/stable/

Apache License 2.0

478 stars 195 forks source link

Update Thrust CMake Guide link in README.md #1593

Closed pauleonix closed 3 months ago

pauleonix commented 3 months ago

Description

The README still linked to the archived Thrust repo instead of the new CCCL repo for the Thrust CMake Guide.

Replace link.

Closes #1592

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.

copy-pr-bot[bot] commented 3 months ago

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

wence- commented 3 months ago

Thanks @pauleonix! One minor thing, for reasons, we don't merge to main, but rather a release branch. This is currently branch-24.08. I've retargetted your PR to that base branch, but could you please rebase your (one) commit on top of branch-24.08 and force-push?

wence- commented 3 months ago

/ok to test

wence- commented 3 months ago

/merge

wence- commented 3 months ago

Thanks!

harrism commented 3 months ago

Must be a problem with the GPU on the node running the failing test, seems unrelated. Unfortunately unlike most PRs, this one isn't giving me the option to rerun failed jobs.

wence- commented 3 months ago

Must be a problem with the GPU on the node running the failing test, seems unrelated. Unfortunately unlike most PRs, this one isn't giving me the option to rerun failed jobs.

I was able to now, so have kicked that run off again.