rapidsai / rmm

RAPIDS Memory Manager
https://docs.rapids.ai/api/rmm/stable/
Apache License 2.0
472 stars 192 forks source link

[FEA] Remove factory functions from resource adaptors #1616

Open mhaseeb123 opened 2 months ago

mhaseeb123 commented 2 months ago

Consider removing factory functions with constructors in prefetch_resource_adaptor, statistics_resource_adaptor, logging_resource_adaptor and others in rmm.

More context at:

         question: can't this just be a constructor? > Why do we need a factory function?

_Originally posted by @jrhemstad in https://github.com/rapidsai/rmm/pull/1608#discussion_r1674886164_

### Tasks
- [x] Change calls to adaptor factories across RAPIDS repos to use constructors
- [ ] https://github.com/rapidsai/rmm/issues/1641
- [ ] Remove deprecated adaptor factories in 24.12
harrism commented 1 month ago

All of these classes already have constructors. I think what you mean is we should remove the factory functions.

bdice commented 1 month ago

I opened two PRs, #1625 and #1626, that should help with this.

harrism commented 1 month ago

Added tasklist to this issue.