rapidsai / rmm

RAPIDS Memory Manager
https://docs.rapids.ai/api/rmm/stable/
Apache License 2.0
492 stars 198 forks source link

[BUG] Deprecations warnings should be errors #1727

Closed harrism closed 1 week ago

harrism commented 1 week ago

Describe the bug RMM test and benchmark CMakeLists.txt disable warnings as errors for deprecated declarations by specifying -Wno-error=deprecated-declarations. Currently we have direct usage of deprecatedrmm::logger()in the replay benchmarkreplay.cpp` which results in warnings, but no errors.

See also rapidsai/build-planning#26

Steps/Code to reproduce bug Build with -DBUILD_BENCHMARKS=ON

Expected behavior All warnings should be treated as errors and there should be no warnings.

Environment details (please complete the following information):