rapidsai / shared-actions

0 stars 3 forks source link

Telemetry: Replace go-based otel-cli with python one #22

Open msarahan opened 2 days ago

msarahan commented 2 days ago

There are 2 options for opentelemetry CLI:

The go-based one is a lot more fleshed-out. It's also much larger to download and occasionally fails with connection errors. The Python one would need some work before it would meet our needs. The attributes functionality is not connected, and it does not handle TRACEPARENT in quite the same way.

We could also look at writing a Python script using the opentelemetry python API, or even send requests with curl. At any rate, something to work on when there's time.

Closes #27 Closes #26 Closes #25

bdice commented 1 day ago

We should pre-install this into our CI images. We need to minimize the number of network requests during our CI execution, and having it available ahead of time would help with that.

msarahan commented 11 hours ago

It's pretty awful to parse this stuff in GHA. It's just really hard to test and develop. I'm going to open a new issue to refactor the process. I think that we can use Python in the github actions (thanks to the "dispatch" idea, a .py file should be usable). By using Python, we can use the opentelemetry API/SDK libraries for Python, and that will get rid of the otel-cli download. Python will also be much more flexible for putting out information like what you request here.

There are several shortcomings with the current implementation, which does the following:

Other issues capture some of the shortcomings: