search

rapidsai / spark-examples

[ARCHIVED] Moved to github.com/NVIDIA/spark-xgboost-examples
https://github.com/NVIDIA/spark-xgboost-examples
Apache License 2.0
70 stars 40 forks source link

ETL/Taxi_ETL.ipynb result have some problem #58

Closed mao-ouyang closed 5 years ago

mao-ouyang commented 5 years ago
  1. The year, month, and day series passed by this function uses the reference instead of passing the value, thus causing the original data to be modified. image Improve proposals： image
  2. When exporting data using pandas, the index column should be removed. image Improve proposals： image
krajendrannv commented 5 years ago

Thanks for your feedback. Please feel free to submit a pull request.

chuanlihao commented 5 years ago

Hi @mao-ouyang , thanks for pointing out these issues.

You are correct. I have verified these issues on my local server. There is one more issue that "train_part_path_csv" should be updated to "test_part_path_csv" when saving csv test data.

It would be great if you could submit a pull request to fix these issues. If you don't have time to do it, please let me know then I will fix the issues. Thanks a lot.

anfeng commented 5 years ago

Assuming the issue was resolved per latest suggestion. Feel free to reopen if you still have the problem