search

rapidsai / ucx-wheels

BSD 3-Clause "New" or "Revised" License
1 stars 4 forks source link

publish v1.14.1.post1 #6

Closed jameslamb closed 6 months ago

jameslamb commented 6 months ago

Follow-up to #5.

Proposes publishing a 1.14.1.post1 version, identical to version 1.14.1 except that load_library() will no longer raise exceptions in non-GPU environments.

Notes for Reviewers

~Just putting this up to get in the CI run. Should probably wait to merge it until testing on https://github.com/rapidsai/ucx-py/pull/1041 is done.~

pentschev commented 6 months ago

No opposition from me if there's a specific use case, but notice that we don't support 1.14.x anymore, see https://github.com/rapidsai/ucx-py/blob/c1c34669d5b295c0d5f260e3c38de1dfe00efb32/dependencies.yaml#L118-L120 and https://github.com/rapidsai/ucx-py/blob/c1c34669d5b295c0d5f260e3c38de1dfe00efb32/conda/recipes/ucx-py/meta.yaml#L38, the same is true for UCXX.

jameslamb commented 6 months ago

Oh ok, thank you!

I'll let @vyasr comment, but I think we're looking to patch every libucx we've published from this repo (v1.14, v1.15, v1.16) just for completeness. So that, for example, rolling back to v1.14.0 or integrating some other project that requires v1.14.0 will still be able to benefit from these wheels.

If you're curious, you can see the versions that have been published at https://pypi.anaconda.org/rapidsai-wheels-nightly/simple/libucx-cu12/

image

Which makes me realize... this should really be 1.14.1.post1, not 1.14.0.post1. Just pushed a commit with that change: https://github.com/rapidsai/ucx-wheels/pull/6/commits/f15aef5ae0dd84e8d6a9a8aaab7b0a20c9406bad

vyasr commented 6 months ago

Yup James is right, the goal here is to supersede the first round of wheels (even for versions of libucx that RAPIDS isn't using) so that we don't publish broken libraries.