Closed zhuofan1123 closed 5 months ago
This PR refactors the embedding creation interface, decoupling it from the optimizer dependency. Users now can designate the embeddings for optimization during optimizer initialization. cpp:
wholememory_create_embedding(&wm_embedding, ...); wholememory_create_embedding_optimizer(&optimizer, ...); wholememory_embedding_set_optimizer(wm_embedding, optimizer);
python:
wm_embedding = wgth.create_embedding(...) wm_optimizer = wgth.create_wholememory_optimizer(wm_embedding, "adam", {})
This pull request requires additional validation before any workflows can run on NVIDIA's runners.
Pull request vetters can view their responsibilities here.
Contributors can view more details about this message here.
/okay to test
/merge
This PR refactors the embedding creation interface, decoupling it from the optimizer dependency. Users now can designate the embeddings for optimization during optimizer initialization. cpp:
python: