search

rapidsurveys / odkr

Open Data Kit R API
http://rapidsurveys.io/odkr/
GNU General Public License v3.0
11 stars 4 forks source link

Add export options #53

Closed jwrozelle closed 3 years ago

jwrozelle commented 3 years ago
ernestguevarra commented 3 years ago

@jwilliamrozelle thanks for the pull request.

Everything seems to be in order though Travis and GitHub Actions still going.

I will merge this pull request once all checks go through. But before I do, can you amend the pull request to add your name to DESCRIPTION and assign yourself as contributor?

Also, do you have any inputs for testing the options you've provided? Would be good to add those eventually over time. All we'll need will be sample datasets from an ODK Aggregate that we can communicate with with encryption and with the Geo components. Let me know if you have any ideas for those.

jwrozelle commented 3 years ago

Sure, happy to update the description!

I could add some inputs for testing - I saw that you're using a test server on ONA. I could potentially add a dataset there that's encrypted, and include a sample encryption key.

That shouldn't be too difficult. I separately sent an email a few minutes ago introducing myself. Looks like there was 403 error for why it failed the test - I don't think anything I edited should have caused that, but I can look. Any thoughts?

I could add those in the next week or so.

Thanks

On Tue, Mar 2, 2021 at 3:47 PM Ernest Guevarra notifications@github.com wrote:

@jwilliamrozelle https://github.com/jwilliamrozelle thanks for the pull request.

Everything seems to be in order though Travis and GitHub Actions still going.

I will merge this pull request once all checks go through. But before I do, can you amend the pull request to add your name to DESCRIPTION and assign yourself as contributor?

Also, do you have any inputs for testing the options you've provided? Would be good to add those eventually over time. All we'll need will be sample datasets from an ODK Aggregate that we can communicate with with encryption and with the Geo components. Let me know if you have any ideas for those.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rapidsurveys/odkr/pull/53#issuecomment-789204739, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZNPHYOVNQ6Z4YJGWG5MF3TBVFHVANCNFSM4YPV334A .

ernestguevarra commented 3 years ago

The testing coverage is set in such a way that when something new is added without new testing parameters, it will alert me that testing coverage goes down. That's not a big issue. I am not particular about that failing. But ideally, and I myself am not good in following this, it would be good for new edits and new functions to come with a testing suite already.

For this project, since it got archived on CRAN, i have loosened up a bit on testing (hence the 50% coverage) and have just been finding time to get it up to high standards again.

Let's wait up on the testing. We can work on that better together over time, if you would like to further collaborate?

I have been splitting my efforts on developing another app that is more of an API interface to ONA and KoboToolbox - see https://github.com/rapidsurveys/okapi. I would like for odkr and okapi to sort of mature together.

jwrozelle commented 3 years ago

Yes, I would be happy to further collaborate and contribute where helpful!

I'd been separately developing some things myself, but what you've got is far more mature. I think my time would be better spent contributing and supporting what you've already built, rather than re-building something that already exists.

I'll push the updated odkr shortly - with an updated description.

On Tue, Mar 2, 2021 at 4:00 PM Ernest Guevarra notifications@github.com wrote:

The testing coverage is set in such a way that when something new is added without new testing parameters, it will alert me that testing coverage goes down. That's not a big issue. I am not particular about that failing. But ideally, and I myself am not good in following this, it would be good for new edits and new functions to come with a testing suite already.

For this project, since it got archived on CRAN, i have loosened up a bit on testing (hence the 50% coverage) and have just been finding time to get it up to high standards again.

Let's wait up on the testing. We can work on that better together over time, if you would like to further collaborate?

I have been splitting my efforts on developing another app that is more of an API interface to ONA and KoboToolbox - see https://github.com/rapidsurveys/okapi. I would like for odkr and okapi to sort of mature together.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rapidsurveys/odkr/pull/53#issuecomment-789211678, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZNPH2JGLQSZMREWFTKTTDTBVGVBANCNFSM4YPV334A .

jwrozelle commented 3 years ago

apologies - made a minor mistake - please ignore this push, and will submit another in a few minutes

codecov-io commented 3 years ago

Codecov Report

Merging #53 (77ddb8f) into master (d2b69a7) will decrease coverage by 5.01%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   50.27%   45.26%   -5.02%     
==========================================
  Files          11       11              
  Lines         183      190       +7     
==========================================
- Hits           92       86       -6     
- Misses         91      104      +13
Impacted Files Coverage Δ
R/export_data.R 31.42% <0.00%> (-11.43%) :arrow_down:
R/get_help.R 66.66% <0.00%> (-11.12%) :arrow_down:
R/get_briefcase.R 81.25% <0.00%> (-6.25%) :arrow_down:
R/pull_local.R 55.00% <0.00%> (-5.00%) :arrow_down:
R/push_data.R 44.00% <0.00%> (-4.00%) :arrow_down:
R/pull_remote.R 32.35% <0.00%> (-2.95%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d2b69a7...77ddb8f. Read the comment docs.

jwrozelle commented 3 years ago

Okay - the latest push should be good. Forgot to re-run roxygenise, and caught a parenthesis mistake when I did.

ernestguevarra commented 3 years ago

@jwilliamrozelle I've merged this to master. Thanks for the pull request and contribution. Sorry for the delay as I was busy with lots of teaching the the past 4 days of this week.

jwrozelle commented 3 years ago

No worries, thanks for the update!

On Thu, Mar 4, 2021, 3:29 PM Ernest Guevarra notifications@github.com wrote:

@jwilliamrozelle https://github.com/jwilliamrozelle I've merged this to master. Thanks for the pull request and contribution. Sorry for the delay as I was busy with lots of teaching the the past 4 days of this week.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rapidsurveys/odkr/pull/53#issuecomment-790918708, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZNPHZUEILNJH4YNDVXY53TB7URXANCNFSM4YPV334A .