search

rapidwebltd / php-google-contacts-v3-api

👥 PHP library for the Google Contacts API (v3)
MIT License
102 stars 64 forks source link

Extract the phone number trough the xml __toString method. #33

Closed dquak closed 7 years ago

DivineOmega commented 7 years ago

Hi there! Thanks for the contribution. May I ask what problem this fixes?

dquak commented 7 years ago

Ofcourse, sorry for the lack of information. It seem that during the extract of the phone number from getAll () method, the phoneNumber field returnes false. short workaround as this seems to fix it.

On Mar 14, 2017 01:44, "Jordan Hall" notifications@github.com wrote:

Hi there! Thanks for the contribution. May I ask what problem this fixes?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rapidwebltd/php-google-contacts-v3-api/pull/33#issuecomment-286278402, or mute the thread https://github.com/notifications/unsubscribe-auth/ALm39ai2av5pySHdcL_GshV4BzXG7f4zks5rldT4gaJpZM4Maesx .

DivineOmega commented 7 years ago

Alright, thanks.

The phone number should appear in the e164 attribute. I would guess the phone number you are trying to read does not match the E.164 format perhaps, and Google is therefore not including it.

https://en.wikipedia.org/wiki/E.164

Would you mind seeing if this is the case in the contact(s) you're testing with?

DivineOmega commented 7 years ago

Regardless, this is worth merging, but I'd be very curious to find out why your contact phone numbers are not coming through in the e164 attribute.