Performance improvment #2 - Githubissues

rapidwebltd / php-uk-bank-holidays

🏖️ PHP UK Bank Holidays lets developers easily retrieve UK bank holiday details.

GNU Lesser General Public License v3.0

13 stars 3 forks source link

Performance improvment #2 #7

Open 200MPH opened 4 years ago

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 47

10 of 12 (83.33%) changed or added relevant lines in 2 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-14.5%) to 80.328%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/Factories/UkBankHolidayFactory.php	8	10	80.0%
<!--	Total:	10	12	83.33%	-->

Files with Coverage Reduction	New Missed Lines	%
src/Objects/DataRetrievers/GovUkDataRetriever.php	1	75.86%
src/Objects/CacheDrivers/LaravelCacheDriver.php	6	0%
<!--	Total:	7		-->

Totals
Change from base Build 44:	-14.5%
Covered Lines:	49
Relevant Lines:	61

💛 - Coveralls

200MPH commented 4 years ago

Hello, Coverage still returns a fail. I do not know how to fix it.