rapier1 / hpn-ssh

HPN-SSH based on OpenSSH
https://psc.edu/hpn-ssh-home
Other
319 stars 43 forks source link

Update to 18.4.1 #81

Closed rapier1 closed 5 months ago

rapier1 commented 5 months ago

This fixes an issue with the channel output buffer growing to unsustainable sizes causing disconnects in some situations. It also results in sshbuf code that more closely conforms to the OpenSSH source while retaining the buffer enhancements. This passes all regression tests, unit tests, and functionality tests.

Additionally, We've remove the HPNBufferLimit option as it turns out that it wasn't working as advertised. More often than not it would cause an immediate connection termination. As this option is not widely used, if at all, I feel that removing it is the best course of action.

Also, minor fixes including a small memory leak in kex.c and compatibility for OpenSSL 3.4.

rapier1 commented 5 months ago

MWD has too much on their plate at the moment so we are skipping the second review for this. Pushing this out to RC status on my authority.