search

rapier1 / hpn-ssh

HPN-SSH based on OpenSSH
https://psc.edu/hpn-ssh-home
Other
333 stars 45 forks source link

Linking failure on big endian (s390x) #93

Closed ellert closed 1 month ago

ellert commented 4 months ago

/usr/bin/ld: umac128.o (symbol from plugin): in function umac_put_u32_le': (.text+0x0): multiple definition ofumac_put_u32_le'; umac.o (symbol from plugin):(.text+0x0): first defined here collect2: error: ld returned 1 exit status

This function (umac_put_u32_le) has been enclosed in a

#if (! __LITTLE_ENDIAN__) /* compile time warning thrown otherwise */

block in order to fix this issue for little endian architectures. Since the function is not used on big endian architectures either, this can be fixed by changing the above to

#if 0 /* compile time warning thrown otherwise */
rapier1 commented 4 months ago

I need to review this entire patch as I am not sure it's actually providing the performance benefit I think it is providing. If it isn't then I need to revert this entire patch. One way or the other this will be resolved in the next release.

rapier1 commented 1 month ago

This will be available in HPN-SSH 18.6.0. However, we don't use the master branch for development so things that impact functionality have to go into a sub-branch that we then merge in. So while this PR looks like it's getting rejected it absolutely isn't. I just wanted to let you know.

rapier1 commented 1 month ago

This change has been added to 18.6.0.

Thanks for submitting this PR!