search

rapila / cms-base

The rapila cms’ internals. Please file all issues here if they’re not directly related to a plugin or the sample site.
http://www.rapi.la
3 stars 1 forks source link

Login (/cms_login/) is reloading in a loop (widgetInformation.methods is undefined) #234

Closed juergmessmer closed 6 years ago

juergmessmer commented 6 years ago

http://domain/cms_login/ Endless loop of reloading the page: js error thrown: loadInfo / widgetInformation.methods is undefined.

This occurred while testing a protected page with a non-admin/backend user, and was redirected to login.

juergmessmer commented 6 years ago

Logout goes to /cms_login/ too (since I hardly ever logout, I'm not sure, but wouldn't logout redirect to frontend?

juergmessmer commented 6 years ago

Still can't debug it. The only thing I know that admin_menu and documentation_display are instantiated in a loop, why? It's neither admin nor preview?

sabberworm commented 6 years ago

I’m not sure when we broke this but I think we introduced the reload loop when we added the reload if we get a NotLoggedInException (or whatever it’s called).

juergmessmer commented 6 years ago

You relate to commit https://github.com/rapila/cms-base/commit/ebad71c5fbca88f694ea354bfc85c8ef47dac86b ?

sabberworm commented 6 years ago

I think so

On Mon, Jun 4, 2018 at 11:19 AM, Jürg Messmer notifications@github.com wrote:

You relate to commit ebad71c https://github.com/rapila/cms-base/commit/ebad71c5fbca88f694ea354bfc85c8ef47dac86b ?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/rapila/cms-base/issues/234#issuecomment-394289298, or mute the thread https://github.com/notifications/unsubscribe-auth/AAC6JJSF36loZ5GE-Pnd1DHx8Rkz0eDbks5t5PuSgaJpZM4UCpA5 .

sabberworm commented 6 years ago

@juergmessmer Can you check if this is fixed now?

juergmessmer commented 6 years ago

The original issue is fixed.

But two behaviors are not quite the way they should be.

  1. Admin logout redirects to cms_login instead of the last page used as before
  2. A authenticated user that may view protected page is not redirected to login_referrer_page (remains in cms_login and displays logout link)
juergmessmer commented 6 years ago

Position 1 (Admin logout...) behavior happens only in Firefox, not in Safari!

juergmessmer commented 6 years ago

I moved the position 2 (cms_login:redirect to referrer) to it's own issue #242, so this can be closed