search

rapila / cms-base

The rapila cms’ internals. Please file all issues here if they’re not directly related to a plugin or the sample site.
http://www.rapi.la
3 stars 1 forks source link

Parsed css for page_detail containers display doesn't work #241

Open juergmessmer opened 6 years ago

juergmessmer commented 6 years ago

No containers are displayed, no errors use_parsed_css_in_config: true

juergmessmer commented 6 years ago

this setting also affects correct loading of page js: clicking on edit template and page type dialog doesn't work (Safari). Also changes in templates don't take effect when clearing the caches (Safari and Firefox).

sabberworm commented 6 years ago

Does this affect 1.7 or 1.5 as well or only master?

juergmessmer commented 6 years ago

I’ll have to test it

juergmessmer commented 6 years ago

I can't test it anymore since release-1.5 is not compatible with my php 7 environment.

sabberworm commented 6 years ago

Tested with cms-full. Both branches (master and release-1.7) work fine.

screen shot 2018-06-18 at 21 18 49
sabberworm commented 6 years ago

But there are many CSS3 (and beyond) features that PHP-CSS-Parser does not support. Maybe your site uses one of those?

juergmessmer commented 6 years ago

I don't understand all the issues, for example https://github.com/sabberworm/PHP-CSS-Parser/issues/125 Regarding background-position, I only use background-position: left center; not the suggested background-position: top left, right bottom;

sabberworm commented 6 years ago

I don't understand all the issues, for example https://github.com/sabberworm/PHP-CSS-Parser/issues/125 Regarding background-position, I only use background-position: left center; not the suggested background-position: top left, right bottom;

Well, then it does not apply to you, does it?

sabberworm commented 6 years ago

Also I think you mean sabberworm/PHP-CSS-Parser#123, not 125

juergmessmer commented 6 years ago

No, I meant the one related to "... declare color", I didn't understand that issue. The one related to background-position I checked and couldn't find any rules using the statements suggested in the related issue.