search

rapila / cms-base

The rapila cms’ internals. Please file all issues here if they’re not directly related to a plugin or the sample site.
http://www.rapi.la
3 stars 1 forks source link

Admin list reorder sort by d&d doesn't work anymore #245

Closed juergmessmer closed 5 years ago

juergmessmer commented 6 years ago

In both admin documents and links list.

Version: master, it still worked in release-1.7.

Assumed reason: Introduction of hash_key must have broken this.

Observed: As soon as you choose sort asc while a categeory is chosen, the sortable icons in the sort column disappear. (list.allowSort does return true!)

juergmessmer commented 6 years ago

I can't figure out what's really happening. If a category is chosen and the sort order is "sort" and "asc", the class .ui-sortable-handle is removed. It looks like it could be related to the update to jQuery 3. See this error when stopping on a breakpoint.

screen shot 2018-07-05 at 07 03 25
sabberworm commented 6 years ago

This error is completely unrelated. It’s a browser compatibility test done by the jQuery selector engine sizzle.

juergmessmer commented 6 years ago

Yes, I just noticed because it happens independently of module and sort order.

juergmessmer commented 6 years ago

I tried to further examine it, but havn't found out yet what it could be. When I look at the admin/widget/resources change history I can only imagine that it's somehow related to the hashkey changes (probably not?) or jquery/UI update.

@sabberworm : It exceeds my debug capabilities... please have a look at it asap since sorting - particularly document (image galleries) - is widely used.

sabberworm commented 5 years ago

Fixed with fde3141