rapila / cms-base

The rapila cms’ internals. Please file all issues here if they’re not directly related to a plugin or the sample site.
http://www.rapi.la
3 stars 1 forks source link

PHP 8 compatibility #268

Closed sabberworm closed 2 years ago

sabberworm commented 2 years ago

At least propel needs an update…

[10-Nov-2021 08:30:56 UTC] PHP Fatal error:  Declaration of PropelPDO::query() must be compatible with PDO::query(string $query, ?int $fetchMode = null, mixed ...$fetchModeArgs) in /home/elternr4/site/base/lib/vendor/propel/runtime/lib/connection/PropelPDO.php on line 451
[10-Nov-2021 08:30:56 UTC] PHP Fatal error:  Declaration of PropelPDO::query() must be compatible with PDO::query(string $query, ?int $fetchMode = null, mixed ...$fetchModeArgs) in /home/elternr4/site/base/lib/vendor/propel/runtime/lib/connection/PropelPDO.php on line 451
sabberworm commented 2 years ago

Also see discussion in #264

sabberworm commented 2 years ago

Because of PDO interface changes, it was deemed too complicated to be PHP 8 and 7 compatible. release-1.8 branch will remain PHP 7 only and master branch will be PHP 8+ only.