search

rapiz1 / rathole

A lightweight and high-performance reverse proxy for NAT traversal, written in Rust. An alternative to frp and ngrok.
Apache License 2.0
8.82k stars 441 forks source link

Add easy musl #301

Closed zhfish closed 7 months ago

zhfish commented 8 months ago

I added dependencies to Cargo, ensuring that OpenSSL is correctly included with features during the compilation of musl, eliminating the need to separately handle OpenSSL for musl. We still find musl necessary because handling dependencies can be quite challenging.

300

rapiz1 commented 8 months ago

Not sure it's the right thing to do. Vendored openssl has various drawbacks e.g. it can't respect the system root certificate, and it doesn't get updated so it's not as secure. Also I wonder if this impact binary size

zhfish commented 8 months ago

My system is Rocky8, and the Glib version is 2.28, which is very inconvenient to upgrade. Although the size of the binary file has been increased, I believe it is well worth it

rapiz1 commented 8 months ago

In that case, can you try only vendor openssl for musl release?

zhfish commented 8 months ago

You're right. I've made the modifications, enabling vendor dependencies exclusively for musl compilation.