search

rapodaca / dialect

Documenting a subset of the SMILES language.
MIT License
13 stars 0 forks source link

Text should replace "eligible atoms" #69

Closed rapodaca closed 2 years ago

rapodaca commented 2 years ago

"Eligible" is used generically in the text, but is also defined as with implicit hydrogen counts. It's not clear that this definition (line 199), even if the term is changed, needs to be kept given the new hydrogens enumeration. References to "eligible" in the sense of virtual-hydrogen-computable should be removed.

Delete the definition, then find all occurrences of the word "eligible." If referring to implicit hydrogen counting, replace with the new enum-based definition.

rapodaca commented 2 years ago

"Eligible" is also used to mean "selectable." Maybe swap that usage as well.