[Web Services]: Allow for enabling verbose mode

rapp-project / rapp-platform

RAPP Platform is a collection of ROS nodes and back-end processes that aim to deliver ready-to-use generic services to robots

Other

28 stars 20 forks source link

[Web Services]: Allow for enabling verbose mode #353

Closed klpanagi closed 7 years ago

etsardou commented 7 years ago

@maciek-slon what exactly did you mention about the verbose mode? What kind of additional information you wanted to be seen?

maciek-slon commented 7 years ago

At the moment I can see something like this when calling service:

1 REQUEST.serv (+1): POST *://anonymous@127.0.0.1:9001 /hop/object_detection_find_objects HTTP/1.1
1 INVOKE.svc (object_detection_find_objects . #|JsObject [__proto__: JsObject] [extensible: #t] [properties: ()] [cmap: JsConstructMap] [elements: vector]|)

It would be nice to have possibility to see full request and response, or at least JSONs that are received and sent back

etsardou commented 7 years ago

@klpanagi is this possible?

klpanagi commented 7 years ago

Yeap, we will have to update only the WebService HOP wrapper and include a logger. I will also add an option to redirect logs to either stdout or log-files. Does not require too much effort, so i think an update will be ready by the end of the week

klpanagi commented 7 years ago

Logging improvements include:

Added a proper logger that captures request and response descriptors. Includes timestamps and pretty-print.
Debug mode: Stream logs to stdout. Enable/Disable via config file here
Log-Files: Stream logs to files. Enable/Disable usage of log-files via config file here
Lower HOP Verbosity.

Enabling both Debug and Log-Files will stream logs to both stdout and log-files

@maciek-slon Please chechout to that branch (logging_web_svc) and let us know if logging is sufficient in order to perform a merge to master branch