rapp-project / rapp-robots-api

Includes the robot-agnostic RAPP API calls, as well as per-robot implementations
Apache License 2.0
2 stars 2 forks source link

Build error on branch WUT #24

Open klpanagi opened 7 years ago

klpanagi commented 7 years ago

Hi @maciek-slon and @dudekw,

following https://github.com/rapp-project/rapp-robot-nao/issues/15#issuecomment-271120081, i get a build error on branch wut (missing namespaces)

The produced error is:

/home/nao/ws_rapp_api/src/rapp-robots-api/cpp/implementations/localization.cpp:81:16: error: prototype for 'const void rapp::robot::localization::euler_from_quaternion(const rapp::object::quaternion&, std::array<float, 3u>&)' does not match any in class 'rapp::robot::localization'
     const void localization::euler_from_quaternion(const rapp::object::quaternion &rapp_quaternion, std::array<float,3> &euler){
                ^
In file included from /home/nao/ws_rapp_api/src/rapp-robots-api/cpp/implementations/localization.cpp:3:0:
/home/nao/ws_rapp_api/install/include/rapp-robots-api/localization/localization.hpp:54:24: error: candidate is: std::vector<float> rapp::robot::localization::euler_from_quaternion(rapp::object::quaternion&)
     std::vector<float> euler_from_quaternion(rapp::object::quaternion &rapp_quaternion);
                        ^
make[2]: *** [cpp/implementations/CMakeFiles/rapp_robot_localization.dir/localization.cpp.o] Error 1
make[1]: *** [cpp/implementations/CMakeFiles/rapp_robot_localization.dir/all] Error 2
make: *** [all] Error 2
[ 20%] Built target rapp_robot_communication
[ 40%] Built target rapp_robot_info
[ 60%] Building CXX object cpp/implementations/CMakeFiles/rapp_robot_localization.dir/localization.cpp.o
/home/nao/ws_rapp_api/src/rapp-robots-api/cpp/implementations/localization.cpp:81:16: error: prototype for 'const void rapp::robot::localization::euler_from_quaternion(const rapp::object::quaternion&, std::array<float, 3u>&)' does not match any in class 'rapp::robot::localization'
     const void localization::euler_from_quaternion(const rapp::object::quaternion &rapp_quaternion, std::array<float,3> &euler){
                ^
In file included from /home/nao/ws_rapp_api/src/rapp-robots-api/cpp/implementations/localization.cpp:3:0:
/home/nao/ws_rapp_api/install/include/rapp-robots-api/localization/localization.hpp:54:24: error: candidate is: std::vector<float> rapp::robot::localization::euler_from_quaternion(rapp::object::quaternion&)
     std::vector<float> euler_from_quaternion(rapp::object::quaternion &rapp_quaternion);
                        ^
make[2]: *** [cpp/implementations/CMakeFiles/rapp_robot_localization.dir/localization.cpp.o] Error 1
make[1]: *** [cpp/implementations/CMakeFiles/rapp_robot_localization.dir/all] Error 2
make: *** [all] Error 2

Can you provide a fix for this?

dudekw commented 7 years ago

Did you remove the build and install folder of the ~/ws_rapp_api workspace before pulling the wut branch and compiling the rapp-robots-api repository ?

klpanagi commented 7 years ago

Thank you @dudekw that worked!

It would be nice to have the vm_compile_rapp_api.sh script handle this.