search

rappasoft / laravel-boilerplate

The Laravel Boilerplate Project - https://laravel-boilerplate.com
https://rappasoft.com
5.59k stars 1.58k forks source link

5.3 Update #485

Closed rappasoft closed 8 years ago

rappasoft commented 8 years ago

Been working on a ground up since 5.3 came out. Much more changed than I thought. Probably about 30% done.

Will keep everyone posted.

blomdahldaniel commented 8 years ago

2.

Aah, I think I se your point! I think that Gravatar should be the first option that gets selected by default. But then, from My Profile or Settings the user can choose wether to use:

Is that what you are saying? In that case I am totally on board with your idea.

I think we should do a remake of the Dashboard/My Profile/Settings any way so I think that would be a good feature to add there. One thing though is that we would have to decide is where the app should store the picture. So we should then have to be opinionated about the storage. Not a big thing since defaulting to local storage is ok I guess but we would have to make that decision.

nasirkhan commented 8 years ago

@blomdahldaniel updated the previous comment on suggestion 1.

nasirkhan commented 8 years ago

2 About the image selection options, we both on the same page now :smile: . Along with the frontend dashboard this profile change option should be available from backend as well. We may store the images at public/img/frontend/user_profile_pic directory and it will be ignored by default

blomdahldaniel commented 8 years ago

😄 Yeah sure public/img/frontend/user_profile_pic would be ok. Backend as well...? All users, no matter roles or permissions, should edit their settings or Profile in the same place in my opinion. Therefore there should only be an option to set the profile pic in the frontend Settings/My Profile area..?

Or do you think there should be a backend option whether the user will be able to edit the profile picture or not? Because in that case I think that would be over-doing it. Just a hardcoded config option would be sufficient in my opinion?

rappasoft commented 8 years ago

I believe the current way to store images is in the storage directory, and to create a symlink to public. I remember seeing it somewhere in the laravel docs.

num3thod commented 8 years ago

5.3 even has an artisan command to create the link for you php artisan storage:link

rappasoft commented 8 years ago

It's up to you guys if you want to build in all these requests before it's released. It's going to push the date back, i'm already behind schedule since I don't have a lot of time to work on it.

It's mostly there minus all the requests.

webhanspeter commented 8 years ago

As a non-contributing user of this project, my 2 cents would be, that I think the 5.3 update should be just the support for Laravel 5.3 and additional features like custom avatar support should be for a future release. (Even though the avatar issue is very relevant also. I've actually built a custom solution for this in my own project) Thanks to everyone contributing actively!

rappasoft commented 8 years ago

Doesn't matter to me if you've contributed or not, I use many projects without doing so. Still want to hear yours and everyone else input if you've used it.

Helps me when I have to use it as well.

dafonso commented 8 years ago

IMHO, I'm with @webhanspeter: focus on supporting Laravel 5.3, extra features later. I've found myself other things I'd like to contribute and change, but lacking the time to do it at the moment and also thinking that those maybe aren't really priorities for this project right now. L5.3 is what's really needed for all those out there that want to make the leap in new projects, not user pics.

num3thod commented 8 years ago

Ok I know this thread is already super long, but what would be the appetite for adding a Toatr middleware? If enabled, it allows you to use toasts for all flash messages, instead of the default bootstrap alerts. Very simple and elegant.

Just a thought, albeit self-serving since it's one of the first things I do when starting a new project with L5B.

rappasoft commented 8 years ago

Toastr is already included, but only globally available in the backend js, you can add it to the frontend too if you want in your own project.

We were using it somewhere but have stopped since, so right now it's just included as convenience but you can remove it if you don't need it. I personally like it because it's lightweight and easy to use.

blomdahldaniel commented 8 years ago

All the missing translations for some of the notification emails should now be fixed (nr 1. above). I added the new indexes in all the langs but left the english text where there was no translation from before.

rappasoft commented 8 years ago

Awesome, we hit the 1000 commit mark with those!

nasirkhan commented 8 years ago

Can we set a release date for this version?

rappasoft commented 8 years ago

Was trying, but also trying to accomplish all the PRs and Issues in it, and they keep coming in.

rappasoft commented 8 years ago

Question, does anyone see a problem or security risk with this? https://github.com/rappasoft/laravel-5-boilerplate/commit/e9810793c85634d146bc49e2da9259bc7ba3e7ae#diff-3040de329d5327de8376a023f4aefc71R22

It adds a user object to every view if the user is logged in so you don't have to pass it through, since its a common object to have.

So instead of doing access()->user() in your views you have access to $user, if the user is logged in.

It's null otherwise.

I just want to make sure i'm not overlooking some security flaw.

Edit: I found issues with it where I need to change the name to it to something more specific to avoid problems.

rappasoft commented 8 years ago

Added a view user view, not only because it's good to have, but to also demonstrate history by entity.

nasirkhan commented 8 years ago

If a release date can be decided, then it might be helpful for others who are planning to use this new version.

A suggestion/query; We are using AdminLTE for backend and we did not changed anything within the theme. I think we may change it a little and pull the SASS files form AdminLTE - node_module. Otherwise i have to manually update the files in the asset directory.

minedun6 commented 8 years ago

do you think I can use the development branch for my project or i need to wait for the official release of bp 5.3 ? and is there any way to upgrade to 5.3 from 5.2 without having to copy/paste everything.

blomdahldaniel commented 8 years ago

@nasirkhan You can't have your cake and eat it too ;) You are perfectly fine to just ditch the entire sass/backend folder and use the node_module for AdminLTE instead. However then you have to let go of SASS since AdminLTE only supports LESS in their node package. This project chose SASS and therefore we need all of the files inside the project.

Its hard to set a date on something that is managed in free time. And especially since there is a lot of people sharing ideas and needing help. I think that the development branch is reaching a more stable state. However there will always be buggs and misfits in the early days of a release.

You may all hurry up the release if you can pull down the development branch and try out all the features and make sure everything is working! 🙂

minedun6 commented 8 years ago

@blomdahldaniel yeah but if we are going to wait for all these ideas and sharing, we'll be stuck in version 5.2 for the rest of our live. So I think that we need to stop for now adding stuff atop of each others and leave the rest for other versions so that @rappasoft can get some time to think about new features for upcoming releases.

minedun6 commented 8 years ago

Man this will take forever !!!

Le mar. 25 oct. 2016 15:13, Anthony Rappa notifications@github.com a écrit :

Was trying, but also trying to accomplish all the PRs and Issues in it, and they keep coming in.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rappasoft/laravel-5-boilerplate/issues/485#issuecomment-256046532, or mute the thread https://github.com/notifications/unsubscribe-auth/AETRan3CQl65r-TqjpC8dVVIQWxYzqa-ks5q3g6agaJpZM4KCBVs .

minedun6 commented 8 years ago

If they can hijack laravel auth system then yeah

Le mar. 25 oct. 2016 16:20, Anthony Rappa notifications@github.com a écrit :

Question, does anyone see a problem or security risk with this? e981079

diff-3040de329d5327de8376a023f4aefc71R22

https://github.com/rappasoft/laravel-5-boilerplate/commit/e9810793c85634d146bc49e2da9259bc7ba3e7ae#diff-3040de329d5327de8376a023f4aefc71R22

It adds a user object to every view if the user is logged in so you don't have to pass it through, since its a common object to have.

So instead of doing access()->user() in your views you have access to $user, if the user is logged in.

It's null otherwise.

I just want to make sure i'm not overlooking some security flaw.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rappasoft/laravel-5-boilerplate/issues/485#issuecomment-256066390, or mute the thread https://github.com/notifications/unsubscribe-auth/AETRaj0GFGO5QS1vpmnjHrrj0jDicDkUks5q3h4FgaJpZM4KCBVs .

rappasoft commented 8 years ago

If thats the case then they have access regardless.

rappasoft commented 8 years ago

I have accomplished all I want to. There are no PR's left, and minimum issues.

I'm going to go through the entire codebase and release sometime tomorrow.

I wanted to release this version with tests but it will have to be added at a later date at this point.

Look at the development commits to see whats new today and yesterday.

I'll have to update the wiki after it's launched, as well as the installer project won't work until I update that as well.

rappasoft commented 8 years ago

RELEASED!

Edit: time for a nap