rappasoft / laravel-livewire-tables

A dynamic table component for Laravel Livewire
https://rappasoft.com/docs/laravel-livewire-tables/v2/introduction
MIT License
1.71k stars 320 forks source link

Fix for setFilter - allows setting values at mount/boot #1449

Closed lrljoe closed 8 months ago

lrljoe commented 8 months ago

Addresses a bug where the split approach does not update both arrays, causing the filter to not actually apply correctly when set on boot/mount

All Submissions:

New Feature Submissions:

  1. [X] Does your submission pass tests and did you add any new tests needed for your feature?
  2. [X] Did you update all templates (if applicable)?
  3. [X] Did you add the relevant documentation (if applicable)?
  4. [X] Did you test locally to make sure your feature works as intended?

Changes to Core Features:

codecov[bot] commented 8 months ago

Codecov Report

Merging #1449 (d4b50c5) into v3-develop (2e14794) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head d4b50c5 differs from pull request most recent head 73432e0. Consider uploading reports for the commit 73432e0 to get more accurate results

@@              Coverage Diff              @@
##             v3-develop    #1449   +/-   ##
=============================================
  Coverage         88.11%   88.11%           
  Complexity         1222     1222           
=============================================
  Files                85       85           
  Lines              2971     2971           
=============================================
  Hits               2618     2618           
  Misses              353      353           
Files Coverage Δ
src/Traits/Helpers/FilterHelpers.php 76.37% <100.00%> (ø)