v3 - Fix - Correct setFilter behaviour (#1451)

rappasoft / laravel-livewire-tables

A dynamic table component for Laravel Livewire

https://rappasoft.com/docs/laravel-livewire-tables/v2/introduction

MIT License

1.71k stars 320 forks source link

v3 - Fix - Correct setFilter behaviour (#1451) #1452

Closed lrljoe closed 8 months ago

lrljoe commented 8 months ago

Fix for setFilter -> ensure that it updates both arrays
Update return types

All Submissions:

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

[X] Does your submission pass tests and did you add any new tests needed for your feature?
[X] Did you update all templates (if applicable)?
[X] Did you add the relevant documentation (if applicable)?
[X] Did you test locally to make sure your feature works as intended?

Changes to Core Features:

[X] Have you added an explanation of what your changes do and why you'd like us to include them?
[X] Have you written new tests for your core changes, as applicable?
[X] Have you successfully ran tests with your changes locally?

codecov[bot] commented 8 months ago

Codecov Report

Merging #1452 (bdb9b8b) into v3-master (cbbb283) will not change coverage. Report is 3 commits behind head on v3-master. The diff coverage is n/a.

@@             Coverage Diff              @@
##             v3-master    #1452   +/-   ##
============================================
  Coverage        88.11%   88.11%           
  Complexity        1222     1222           
============================================
  Files               85       85           
  Lines             2971     2971           
============================================
  Hits              2618     2618           
  Misses             353      353

nathan-io commented 8 months ago

Thanks @lrljoe !

I upgraded to beta8, but after doing so, we're getting an exception on the view where we call the table:

[2023-10-26 02:53:02] local.ERROR: Undefined array key "default" {"view":{"view":"/path/to/project/vendor/rappasoft/laravel-livewire-tables/resources/views/components/table/td.blade.php","data":[]},"userId":1,"exception":"[object] (Spatie\\LaravelIgnition\\Exceptions\\ViewException(code: 0): Undefined array key \"default\" at /path/to/project/vendor/rappasoft/laravel-livewire-tables/resources/views/components/table/td.blade.php:14)

If I downgrade back to beta4, everything works again.

lrljoe commented 8 months ago

@nathan-io - if you have published the views, remove the published views, and clear your view cache.

If you're able to share what your configure() looks like, then that'll help me diagnose the issue.

lrljoe commented 8 months ago

@nathan-io - fixed in v3.0.0-beta.9