rappasoft / laravel-livewire-tables

A dynamic table component for Laravel Livewire
https://rappasoft.com/docs/laravel-livewire-tables/v2/introduction
MIT License
1.7k stars 320 forks source link

Removed a UI bug where the table header + column selector has slight white pixels on top #1545

Closed CorwinDev closed 7 months ago

CorwinDev commented 8 months ago

All Submissions:

Changes

lrljoe commented 8 months ago

Cheers for the PR, I'll review this coming weekend and merge in

lrljoe commented 7 months ago

Changed base to develop, approved check runs.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bc4bfa3) 88.98% compared to head (ad34e2b) 88.98%. Report is 3 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1545 +/- ## ========================================== Coverage 88.98% 88.98% Complexity 1264 1264 ========================================== Files 96 96 Lines 2997 2997 ========================================== Hits 2667 2667 Misses 330 330 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lrljoe commented 7 months ago

@CorwinDev - this PR removes the default bg-gray-50 from the thead

This changes the default behaviour from: image

To image

You can note that the table head is no longer grey/gray by default, however, the bulk actions retains the background.

Think the bg-gray-50 needs to stay, but agree around the other adjustment.

lrljoe commented 7 months ago

Will double check this in dev shortly, and merge into develop ahead of next release if working.