rappasoft / laravel-livewire-tables

A dynamic table component for Laravel Livewire
https://rappasoft.com/docs/laravel-livewire-tables/v2/introduction
MIT License
1.76k stars 330 forks source link

v3 - DataTableComponent Cleanup #1570

Closed lrljoe closed 10 months ago

lrljoe commented 10 months ago

SIGNIFICANT PR.

This PR does several things, to avoid unintentional overriding, and to allow for easier use of standard Livewire Lifecycle methods, without overriding the Table Component core methods.

To do this:

THIS IS STILL IN TESTING

All Submissions:

New Feature Submissions:

  1. [X] Does your submission pass tests and did you add any new tests needed for your feature?
  2. [X] Did you update all templates (if applicable)?
  3. [X] Did you add the relevant documentation (if applicable)?
  4. [X] Did you test locally to make sure your feature works as intended?

Changes to Core Features:

lrljoe commented 10 months ago

Test Fixes applied - continuing testing.

Numerous changes to how the core component behaves, moving boot/render methods out into the relevant Traits

Forcing the Traits in "HasAllTraits" to a specific order (to ensure that the boot order remains sane)

codecov[bot] commented 10 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (1a24e11) 88.99% compared to head (c99b38e) 89.08%. Report is 4 commits behind head on develop.

Files Patch % Lines
src/Traits/WithEvents.php 0.00% 4 Missing :warning:
src/Traits/WithColumns.php 91.66% 1 Missing :warning:
src/Traits/WithData.php 90.90% 1 Missing :warning:
src/Traits/WithReordering.php 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1570 +/- ## ============================================= + Coverage 88.99% 89.08% +0.09% - Complexity 1268 1287 +19 ============================================= Files 96 97 +1 Lines 3008 3042 +34 ============================================= + Hits 2677 2710 +33 - Misses 331 332 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.