rappasoft / laravel-livewire-tables

A dynamic table component for Laravel Livewire
https://rappasoft.com/docs/laravel-livewire-tables/v2/introduction
MIT License
1.7k stars 320 forks source link

Changed table default vertical overflow to auto #1573

Closed dmyers closed 7 months ago

dmyers commented 7 months ago

Per our thread on this issue: https://github.com/rappasoft/laravel-livewire-tables/discussions/1141#discussioncomment-7558991

scroll forces the scroll bar always, whereas auto will hide/show it when necessary.

All Submissions:

New Feature Submissions:

  1. [ ] Does your submission pass tests and did you add any new tests needed for your feature?
  2. [ ] Did you update all templates (if applicable)?
  3. [ ] Did you add the relevant documentation (if applicable)?
  4. [x] Did you test locally to make sure your feature works as intended?

Changes to Core Features:

lrljoe commented 7 months ago

I'm away for a few days, but will merge this in next week.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (db0689d) 88.99% compared to head (8341679) 88.99%. Report is 3 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1573 +/- ## ========================================== Coverage 88.99% 88.99% Complexity 1268 1268 ========================================== Files 96 96 Lines 3008 3008 ========================================== Hits 2677 2677 Misses 331 331 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.