[Bug] Auto Inject Assets: Only if component rendered

rappasoft / laravel-livewire-tables

A dynamic table component for Laravel Livewire

https://rappasoft.com/docs/laravel-livewire-tables/v2/introduction

MIT License

1.7k stars 319 forks source link

[Bug] Auto Inject Assets: Only if component rendered #1683

Open yparitcher opened 3 months ago

yparitcher commented 3 months ago

Regression from 65ce4947ab58b77fb3e454423202edd17e414e49 #1371

Fixes: #1587

Check if component is instanceof DataTableComponent so as not to inject on every livewire page, only ones with a datatable component

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

[ ] Does your submission pass tests and did you add any new tests needed for your feature?
[ ] Did you update all templates (if applicable)?
[ ] Did you add the relevant documentation (if applicable)?
[ ] Did you test locally to make sure your feature works as intended?

Changes to Core Features:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?

yparitcher commented 3 months ago

@lrljoe

lrljoe commented 3 months ago

Thanks for the tag!

I'll do my absolute best to give it a look tomorrow, as then I'm not about for a week or two.

The injection code needs another update in general as well, as there's some more core stuff that I've not gotten around to merging in from Livewire core just yet, which albeit were minor tweaks.

Also intending to wrap up the code for "public" usage properly in case people do want to publish it and use it that way, but that's probably a month away.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.14%. Comparing base (6c759e0) to head (44bb82a). Report is 22 commits behind head on develop.

Files	Patch %	Lines
src/Features/AutoInjectRappasoftAssets.php	75.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #1683 +/- ## ============================================= - Coverage 88.16% 88.14% -0.03% - Complexity 1314 1316 +2 ============================================= Files 123 123 Lines 3110 3113 +3 ============================================= + Hits 2742 2744 +2 - Misses 368 369 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

yparitcher commented 2 months ago

@lrljoe ?

lrljoe commented 2 months ago

Apologies, been a bit busy of late! Will look to get this reviewed and merged in this week.

lrljoe commented 1 month ago

Not forgotten! Just need to spin up a fresh test environment to validate this, as I don't use the injection approach!

stale[bot] commented 2 days ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.