search

rappasoft / laravel-livewire-tables

A dynamic table component for Laravel Livewire
https://rappasoft.com/docs/laravel-livewire-tables/v2/introduction
MIT License
1.7k stars 319 forks source link

Scan provided path for all available FQCNs in paths within and outside app folder #1714

Closed marvoh closed 1 month ago

marvoh commented 1 month ago

As we work on newer projects, we find that the scope of functionality begins to become repetitive and therefore you or someone else may have already done some piece of work that you already need. These would typically be installed in the vendors folder through composer.

Some of these packages have models which the user of the end product would need to interact with therefore will require presentation in tables. However, this package at the moment does not accept packages outside app path.

If time permits and resources permits, please consider looking into supporting both scenarios.

lrljoe commented 1 month ago

So will definitely review this in the next week.

Typically I've seen people extending a Vendor Model, rather than directly referencing it, but happy to adjust the Make Command to allow for this.

Not sure whether your PR is causing the test failures, or something else is going on behind the scenes though, your PR shouldn't be breaking pagination from looking at what's changed.

marvoh commented 1 month ago

The breakages are strange also to me. I can stick to best practise and extend the models instead?

lrljoe commented 1 month ago

Can you resolve the conflict in CHANGELOG.md, and let's see if the tests re-run and pass, as they seem to be mostly passing locally (I had one error when running it in a test environment)

lrljoe commented 1 month ago

Think something's changed in core that is causing the test to fail, will disable that test this weekend, and once changelog is updated, it should be mergeable.

lrljoe commented 1 month ago

This will be in the next release (should be this weekend).