rappasoft / laravel-livewire-tables

A dynamic table component for Laravel Livewire
https://rappasoft.com/docs/laravel-livewire-tables/v2/introduction
MIT License
1.7k stars 319 forks source link

Add HTML render support for LinkColumn #1728

Closed code-creeper closed 1 month ago

code-creeper commented 1 month ago

This commit adds the ability to render HTML content in the titles of LinkColumns.

Previously, if a LinkColumn's title was set to an HTML string or a view file and the html() method was called, the HTML content was not rendered correctly. This update ensures that HTML titles are rendered properly when the html() method is used.

Key changes:

This enhancement improves the flexibility and usability of LinkColumns, allowing for more dynamic and formatted link titles in data tables.

All Submissions:

New Feature Submissions:

  1. [x] Does your submission pass tests and did you add any new tests needed for your feature?
  2. [x] Did you update all templates (if applicable)?
  3. [x] Did you add the relevant documentation (if applicable)?
  4. [x] Did you test locally to ensure your feature works as intended?

Changes to Core Features:

lrljoe commented 1 month ago

I've changed the base to develop, and approved the workflow run. Once merged, future PRs won't need approval to run the workflows (but will still need core maintainer to merge in)

I will review this weekend, thank you very much for the PR! Really appreciate people helping keep this a great package.

Please do target develop for PRs going forward, as otherwise merge conflicts always occur, as we flatten the PRs from develop when going into master for a release!

lrljoe commented 1 month ago

You may need to update your fork with the latest "develop" branch updates to get the tests passing, as there's a broken test in "master" (which is fixed in develop).

Will re-merge into your master and see if that fixes the issue :)