search

raptor-ml / raptor

Transform your pythonic research to an artifact that engineers can deploy easily.
https://raptor.ml
Apache License 2.0
148 stars 11 forks source link

[FEEDBACK] Add pre-commit tooling #132

Closed AlmogBaku closed 1 year ago

AlmogBaku commented 2 years ago

Background

No response

What do you propose to do?

The pre-commit toolchain looks quite promising and can help us to standardize and remove contribution barriers.

This is especially relevant for adding tooling around the"conventional commits", and linting.

What have you already tried?

No response

What else should we know?

Dragonfly conventional commit: https://github.com/dragonflydb/dragonfly/blob/main/contrib/scripts/conventional-commits (by @ryanrussell)

^^ quite similar to https://github.com/soerenschneider/conventional-pre-commit-hook

Alternatively, https://github.com/compilerla/conventional-pre-commit

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

AlmogBaku commented 1 year ago

It's actually closed by #213 🙃