search

raptor2101 / Mediathek

GNU General Public License v3.0
45 stars 16 forks source link

Limit each menu to either VideoLinks OR CategoryLinks #80

Closed p-friedrich closed 8 years ago

p-friedrich commented 8 years ago

This is one approach to solve #79

By stopping the search for links if VideoLinks are found, the category doesn't reappear in it's submenu. Additionally it improves performance.

This change however makes it impossible for a submenu to contain videos and subcategories at the same time. I didn't find a case where this would be desired, but it has to be considered. Maybe there is a more elegant way, so feel free to reject the PR.

p-friedrich commented 8 years ago

I just found an example where this PR breaks functionality: Ausgewählte Filme -> Märchen in der ARD is a category among Video links, which would not be shown with these changes.

I suggest not to merge this PR yet, but to search for a better solution. Input would be very welcome.