search

raquo / Airstream

State propagation and event streams with mandatory ownership and no glitches
MIT License
245 stars 28 forks source link

add scalafmt #127

Closed doofin closed 1 month ago

doofin commented 1 month ago

add scalafmt and just formatted all source files

raquo commented 1 month ago

Adding scalafmt would be a good idea in general, but whoever does it needs to also write the scalafmt configuration file to match the current prevailing code formatting style in the codebase. I don't expect that scalafmt can do a 100% match, but it should come pretty close without relying on any special formatter:off comments.

doofin commented 1 month ago

thanks, do you find somewhere scalafmt didn't format nicely so I can take a look? Seems the default style looks ok

raquo commented 1 month ago

Yes, this PR has +10K - 5K line of code changes, almost all of them are undesirable to me. I can tolerate a small number of changes in formatting here and there for the sake of easier collaboration with scalafmt, but I don't want to reformat the whole codebase in some other style, just because it happens to be the default scalafmt preset. Aside from my formatting preferences, massive changes like this also hide the real git history (I mean when using git blame) which is important to me when dealing with complex issues.

doofin commented 1 month ago

understand, I will close this and just format a few number of files while adding scalafmt