align tomdomvc HTML with https://github.com/tastejs/todomvc-app-templ…

raquo / laminar-full-stack-demo

Fully working client + server, dev + prod setup for Scala.js development, showcasing a bunch of Laminar & Scala.js patterns.

https://demo.laminar.dev

MIT License

49 stars 10 forks source link

Closed RoelVanderPaal closed 1 month ago

RoelVanderPaal commented 3 months ago

…ate/blob/main/index.html

mark all as completed
editing (double click)
- the input field should have focus
- empty item should be removed
"items left" number in footer should be in strong tag
localStorage persistence
routing (currently out of scope)

raquo commented 3 months ago

LGTM so far, thanks! Should I merge, or do you plan to implement the other bullet points as well?

RoelVanderPaal commented 3 months ago

I do plan indeed to implement the other points as well, but that will only be next week. I do not mind creating another PR for that.

raquo commented 3 months ago

Cool, no rush! Let's keep it all in this PR then, less overhead that way.

RoelVanderPaal commented 3 months ago

hello @raquo I implemented all the bullet points the PR is ready for review

raquo commented 3 months ago

👍 Looks good, thanks! I'll merge in a few days.