rasbt / LLMs-from-scratch

Implementing a ChatGPT-like LLM in PyTorch from scratch, step by step
https://www.manning.com/books/build-a-large-language-model-from-scratch
Other
27.86k stars 3.16k forks source link

An unusual link in the pdf version (5.1.2 Calculating the text generation loss) #310

Closed labdmitriy closed 1 month ago

labdmitriy commented 1 month ago

Bug description

Hi @rasbt,

I found that in Section 5.1.2 there is a link to the livebook in one of the paragraphs:

Screenshot

This link redirects to the beginning of the Chapter 5 in livebook: https://livebook.manning.com/book/build-a-large-language-model-from-scratch/chapter-5?potentialInternalRefId=81---main-page-content

I saw the similar link before Section 5.1.2 title itself on the same line, but it redirects to the corresponding section in the livebook: https://livebook.manning.com/book/build-a-large-language-model-from-scratch/chapter-5/v-8/section-5-1-2?refid=29

So probably the first link was added by mistake?

Thank you.

What operating system are you using?

None

Where do you run your code?

None

Environment

rasbt commented 1 month ago

Thanks! I agree, it looks like a formatting issue. Good news that these problematic links should be removed in the latest layouts:

Screenshot 2024-08-11 at 6 53 55 AM