search

rasbt / LLMs-from-scratch

Implement a ChatGPT-like LLM in PyTorch from scratch, step by step
https://www.amazon.com/Build-Large-Language-Model-Scratch/dp/1633437167
Other
32.84k stars 3.95k forks source link

Change image url to S3 #337

Closed rasbt closed 2 months ago

rasbt commented 2 months ago

Change image hosting URL to S3 to avoid timeouts.

review-notebook-app[bot] commented 2 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

rasbt commented 2 months ago

Seems like GitHub has temporary issues with rendering images in Jupyter Lab if the images are hosted at an external website. I suspect it's an issue with their caching service. As this PR shows it doesn't help to host the images via a different URL. Hopefully their issue is temporary.

d-kleine commented 2 months ago

About the external links, are only webp images affected by this issue? Or other formats like jpg/jpeg too?

rasbt commented 2 months ago

@d-kleine It seems to affect all image formats in Jupyter notebooks. I created a test repo here where you can see that the images (png, jpg, webp) work fine when embedded in a Markdown file.

However, in Jupyter Lab files, the same images don't render anymore since last week.

However, Jupyter Lab files still render the images if they are inserted via relative links. So, I suspect that their image caching service for notebooks broke.

Two solutions in the meantime are

  1. View the Jupyter files locally
  2. View the Jupyter files online via https://nbviewer.org

I will give it another week or so, and if it still doesn't work, I will consider adding the image files to this GitHub repo directly. (I originally wanted to avoid this because this will add another ~10 Mb to the repository.)

rasbt commented 2 months ago

Since this issue is persisting for 4 days now, I also filed a bug report on GitHub here. Hopefully someone will investigate.

d-kleine commented 2 months ago

I see - yeah, I can confirm this from my side as well. I think I have seen this a while ago too in my own jnbs on Github, was fixed within a few days.

Switching to nbviewer is a good workaround imo 👍🏻

d-kleine commented 2 months ago

Update: Seems like GitHub has fixed the issue 🛠️

rasbt commented 2 months ago

Did it render for you? Unfortunately, when checking, the images still don't render for me :(

d-kleine commented 2 months ago

I am pretty sure it was working again, next time I'll take evidence (screenshots) 🕵🏻 🤣

rasbt commented 2 months ago

This can be closed for now since it's a GitHub bug. See #338 and ticket #2972699