rasbt / LLMs-from-scratch

Implement a ChatGPT-like LLM in PyTorch from scratch, step by step
https://www.amazon.com/Build-Large-Language-Model-Scratch/dp/1633437167
Other
34.28k stars 4.2k forks source link

Updated Llama 2 to 3 paths #413

Closed d-kleine closed 1 month ago

d-kleine commented 1 month ago
review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

d-kleine commented 1 month ago

Do you think is is fine or do you want to make any adjustments (e.g. moving the models in subfolders)?

rasbt commented 1 month ago

Thanks for the update!

Do you think is is fine or do you want to make any adjustments (e.g. moving the models in subfolders)?

I'd say simple (no subfolders) is better