ch16-part1 adjusting 10 to 8 in embed layer def

rasbt / machine-learning-book

Code Repository for Machine Learning with PyTorch and Scikit-Learn

https://sebastianraschka.com/books/#machine-learning-with-pytorch-and-scikit-learn

MIT License

3.66k stars 1.32k forks source link

ch16-part1 adjusting 10 to 8 in embed layer def #110

Open msfasha opened 1 year ago

msfasha commented 1 year ago

A slight adjustment, The first example in ch16, (ch16-part1) is discussing 8 words embedding, but the code is referring to 10 words

torch.manual_seed(123) embed = torch.nn.Embedding(10, 16) --> should become: embed = torch.nn.Embedding(8, 16) embedded_sentence = embed(sentence).detach() embedded_sentence.shape

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.