Label `losses_` docstring as being log loss, not mean squared error

rasbt / machine-learning-book

Code Repository for Machine Learning with PyTorch and Scikit-Learn

https://sebastianraschka.com/books/#machine-learning-with-pytorch-and-scikit-learn

MIT License

3.66k stars 1.32k forks source link

Label `losses_` docstring as being log loss, not mean squared error #98

Closed paw-lu closed 1 year ago

paw-lu commented 1 year ago

The docstring for LogisticRegressionGD.losses_ specifies that is it composed of the mean squared error, when I think it's composed of log loss. Changed the docstring to reflect that.

Thanks for the book!

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

rasbt commented 1 year ago

Awesome, good catch, didn't see that before!