rasbt / mlxtend

A library of extension and helper modules for Python's data analysis and machine learning libraries.
https://rasbt.github.io/mlxtend/
Other
4.82k stars 853 forks source link

Fixes multiple documentation issues #1003

Closed zuari1993 closed 1 year ago

zuari1993 commented 1 year ago

Description

In reference to #995 , I closed that thread, since that fork was outdated.

Below are the changes made in this PR:

Fixes https://github.com/rasbt/mlxtend/issues/849 - Removed the incorrect statement: note that 'support' depends on 'antecedent support' and 'consequent support' via min('antecedent support', 'consequent support') since this is false.

Fixes https://github.com/rasbt/mlxtend/issues/951 - Added references.

Pull Request Checklist

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

codecov[bot] commented 1 year ago

Codecov Report

Base: 77.45% // Head: 77.46% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (b4588f7) compared to base (0a4013e). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1003 +/- ## ========================================== + Coverage 77.45% 77.46% +0.01% ========================================== Files 198 198 Lines 11171 11171 Branches 1406 1406 ========================================== + Hits 8652 8654 +2 + Misses 2305 2304 -1 + Partials 214 213 -1 ``` | [Impacted Files](https://codecov.io/gh/rasbt/mlxtend/pull/1003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka) | Coverage Δ | | |---|---|---| | [mlxtend/evaluate/counterfactual.py](https://codecov.io/gh/rasbt/mlxtend/pull/1003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9ldmFsdWF0ZS9jb3VudGVyZmFjdHVhbC5weQ==) | `100.00% <0.00%> (+6.89%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rasbt commented 1 year ago

Nvm lgtm