Closed zuari1993 closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Base: 77.45% // Head: 77.46% // Increases project coverage by +0.01%
:tada:
Coverage data is based on head (
b4588f7
) compared to base (0a4013e
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Nvm lgtm
Description
In reference to #995 , I closed that thread, since that fork was outdated.
Below are the changes made in this PR:
Fixes https://github.com/rasbt/mlxtend/issues/849 - Removed the incorrect statement:
note that 'support' depends on 'antecedent support' and 'consequent support' via min('antecedent support', 'consequent support')since this is false.Fixes https://github.com/rasbt/mlxtend/issues/951 - Added references.
Pull Request Checklist
./docs/sources/CHANGELOG.md
file (if applicable)./mlxtend/*/tests
directories (if applicable)mlxtend/docs/sources/
(if applicable)PYTHONPATH='.' pytest ./mlxtend -sv
and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g.,PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv
)flake8 ./mlxtend