Update principal_component_analysis.py

muhammadanas0716 commented 1 year ago

Just added an f-string, rather than using the % symbol.

[ ] Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
[ ] Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
[ ] Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
[ ] Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
[ ] Checked for style issues by running flake8 ./mlxtend

rasbt commented 1 year ago

Thanks!!

muhammadanas0716 commented 1 year ago

Some checks failed! Huh!

rasbt commented 1 year ago

Yeah, no worries. Pls fix when you have time and resubmit.

muhammadanas0716 commented 1 year ago

Could you just tell me what went wrong?

rasbt commented 1 year ago

I will leave that as an exercise to check the logs if you don't mind ^^

muhammadanas0716 commented 1 year ago

I always do my homework

muhammadanas0716 commented 1 year ago

Haha, what a mistake!

Was missing out an ". Just made a new PR: #1011

CC: @rasbt

rasbt commented 1 year ago

You can update the PR, no need to make a new one

muhammadanas0716 commented 1 year ago

Ahh...

muhammadanas0716 commented 1 year ago

Right. Just did!

muhammadanas0716 commented 1 year ago

Something else seems wrong!

muhammadanas0716 commented 1 year ago

Are the libraries out of date?

rasbt commented 1 year ago

yeah, something was out of date but it's all good now. thanks!

muhammadanas0716 commented 1 year ago

Lesssssssssssssss gooooooooooooooooooo!

rasbt / mlxtend