rasbt / mlxtend

A library of extension and helper modules for Python's data analysis and machine learning libraries.
https://rasbt.github.io/mlxtend/
Other
4.82k stars 853 forks source link

Added Hmine algorithm #1020

Closed fatihsen20 closed 1 year ago

fatihsen20 commented 1 year ago

Code of Conduct

New feature.

Description

In order to enrich the library and to compare the speed and memory costs of certain algorithms, I added the hmine algorithm to the library.

Related issues or pull requests

None

Pull Request Checklist

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

rasbt commented 1 year ago

PS: Don't worry about the linter above, we can address that (happy to take care of that) at the very end.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 90.59% and project coverage change: +0.13 :tada:

Comparison is base (11b61b9) 77.33% compared to head (21e038d) 77.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1020 +/- ## ========================================== + Coverage 77.33% 77.46% +0.13% ========================================== Files 198 200 +2 Lines 11171 11287 +116 Branches 1461 1480 +19 ========================================== + Hits 8639 8744 +105 - Misses 2318 2324 +6 - Partials 214 219 +5 ``` | [Impacted Files](https://codecov.io/gh/rasbt/mlxtend/pull/1020?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka) | Coverage Ξ” | | |---|---|---| | [mlxtend/frequent\_patterns/tests/test\_hmine.py](https://codecov.io/gh/rasbt/mlxtend/pull/1020?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9mcmVxdWVudF9wYXR0ZXJucy90ZXN0cy90ZXN0X2htaW5lLnB5) | `88.46% <88.46%> (ΓΈ)` | | | [mlxtend/frequent\_patterns/hmine.py](https://codecov.io/gh/rasbt/mlxtend/pull/1020?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9mcmVxdWVudF9wYXR0ZXJucy9obWluZS5weQ==) | `92.06% <92.06%> (ΓΈ)` | | | [mlxtend/frequent\_patterns/\_\_init\_\_.py](https://codecov.io/gh/rasbt/mlxtend/pull/1020?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9mcmVxdWVudF9wYXR0ZXJucy9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ΓΈ)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rasbt commented 1 year ago

Thanks a lot for the update! I will do my best to review it this weekend!

fatihsen20 commented 1 year ago

I always overlook the isort rules. I am sorry πŸ₯²

rasbt commented 1 year ago

No worries about that! The style checks are really not a big deal, we can address those at the very end upon merging.

fatihsen20 commented 1 year ago

Hello, will my pull request be merge? I am very excited about this 😊 @rasbt

rasbt commented 1 year ago

This is a fantastic PR! And sorry, will merge soon! Haven't had a chance to go over the docs yet! I have a question here:

Screenshot 2023-03-27 at 10 44 12 AM

You mentioned

on a large dataset.

but did you mean

on a small dataset.

I.e., the dataset from the example above? No worries about fixing it. I did some other tweaks in the docs and will update soon (pls don't modify the Nb in the meantime due to merge conflicts, Jupyter NB's are still a bit tricky on GitHub πŸ˜…)

fatihsen20 commented 1 year ago

This is a fantastic PR! And sorry, will merge soon! Haven't had a chance to go over the docs yet! I have a question here: Screenshot 2023-03-27 at 10 44 12 AM

You mentioned

on a large dataset.

but did you mean

on a small dataset.

I.e., the dataset from the example above? No worries about fixing it. I did some other tweaks in the docs and will update soon (pls don't modify the Nb in the meantime due to merge conflicts, Jupyter NB's are still a bit tricky on GitHub πŸ˜…)

Sorry, I probably missed it while preparing the document. Yes, there will be a small dataset in the example there. Thank you so much for your hard work 😊

rasbt commented 1 year ago

Oh I thought it was based on the small example at the top. So you ran the benchmark on a small hands-on dataset if I understand it correctly? I think we can leave things as is unless it's not too large and we can add it to the doc repo. What do you think?

fatihsen20 commented 1 year ago

Oh I thought it was based on the small example at the top. So you ran the benchmark on a small hands-on dataset if I understand it correctly? I think we can leave things as is unless it's not too large and we can add it to the doc repo. What do you think?

Yes it was based on the small example above. Since we are testing with small dataset on Doc, it may remain small. I don't think it will be a big problem if we add it this way.

rasbt commented 1 year ago

Ok perfect, then I'd say it's fine as is because the example is already in the notebook.

Should be good to merge then, correct?

fatihsen20 commented 1 year ago

Ok perfect, then I'd say it's fine as is because the example is already in the notebook.

Should be good to merge then, correct?

Okey sir, please 😊

rasbt commented 1 year ago

Merged it @fatihsen20 . Thanks again for this awesome PR! I am hoping to make a new release version on the upcoming weekend