Sklearn normalize depreciation fix

namanmistry commented 1 year ago

Description

The new version of sklearn's LinearRegression does not allow normalize paramter which is depreciated in the newer versions. So I fixed that.

Related issues or pull requests

Fixes Arg normalize to sklearn.linear_model.LinearRegression has been removed in version 1.2 #1035

Pull Request Checklist

[x] Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
[x] Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
[x] Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
[x] Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
[x] Checked for style issues by running flake8 ./mlxtend

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a60f127) 77.27% compared to head (6279cc1) 77.27%.

:exclamation: Current head 6279cc1 differs from pull request most recent head ea83ad6. Consider uploading reports for the commit ea83ad6 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1036 +/- ## ======================================= Coverage 77.27% 77.27% ======================================= Files 200 200 Lines 11307 11307 Branches 1484 1484 ======================================= Hits 8737 8737 Misses 2351 2351 Partials 219 219 ``` | [Impacted Files](https://app.codecov.io/gh/rasbt/mlxtend/pull/1036?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka) | Coverage Δ | | |---|---|---| | [...end/regressor/tests/test\_stacking\_cv\_regression.py](https://app.codecov.io/gh/rasbt/mlxtend/pull/1036?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9yZWdyZXNzb3IvdGVzdHMvdGVzdF9zdGFja2luZ19jdl9yZWdyZXNzaW9uLnB5) | `95.78% <100.00%> (ø)` | | | [...lxtend/regressor/tests/test\_stacking\_regression.py](https://app.codecov.io/gh/rasbt/mlxtend/pull/1036?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9yZWdyZXNzb3IvdGVzdHMvdGVzdF9zdGFja2luZ19yZWdyZXNzaW9uLnB5) | `97.21% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rasbt commented 1 year ago

Thanks for the PR, it looks good to me! Just moved the Changelog entry to the right section and fixed the small typo (depreciated -> deprecated)

rasbt / mlxtend