rasbt / mlxtend

A library of extension and helper modules for Python's data analysis and machine learning libraries.
https://rasbt.github.io/mlxtend/
Other
4.82k stars 853 forks source link

Replaced np.int and np.bool #1040

Closed namanmistry closed 1 year ago

namanmistry commented 1 year ago

Description

As in the issue Leftover use of np.int and np.bool #1034 I have replaced the np.int and np.bool with np.int_ and np.bool_ in the bias_variance_decomp.py and holdout.py files.

Related issues or pull requests

Fixes Leftover use of np.int and np.bool #1034

Pull Request Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f14f4c6) 77.27% compared to head (4e71a7e) 77.27%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1040 +/- ## ======================================= Coverage 77.27% 77.27% ======================================= Files 200 200 Lines 11307 11307 Branches 1484 1484 ======================================= Hits 8737 8737 Misses 2351 2351 Partials 219 219 ``` | [Impacted Files](https://app.codecov.io/gh/rasbt/mlxtend/pull/1040?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka) | Coverage Δ | | |---|---|---| | [mlxtend/evaluate/bias\_variance\_decomp.py](https://app.codecov.io/gh/rasbt/mlxtend/pull/1040?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9ldmFsdWF0ZS9iaWFzX3ZhcmlhbmNlX2RlY29tcC5weQ==) | `68.88% <100.00%> (ø)` | | | [mlxtend/evaluate/holdout.py](https://app.codecov.io/gh/rasbt/mlxtend/pull/1040?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9ldmFsdWF0ZS9ob2xkb3V0LnB5) | `92.85% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rasbt commented 1 year ago

Thanks for the fix!