rasbt / mlxtend

A library of extension and helper modules for Python's data analysis and machine learning libraries.
https://rasbt.github.io/mlxtend/
Other
4.82k stars 853 forks source link

Pyproject and setuptools #1064

Closed jmahlik closed 9 months ago

jmahlik commented 9 months ago

Code of Conduct

Description

Adding the basics for pyproject support and fixes installation from sdist.

Related issues or pull requests

Related https://github.com/rasbt/mlxtend/issues/1062

Pull Request Checklist

rasbt commented 9 months ago

Thanks a lot for the PR. At first glance, the version handling looks fine to me. At some point, I think it could make sense to move it back to a hardcoded version though 😅.

jmahlik commented 9 months ago

It looks like conda is unhappy updating the environment in ci.

I'll see what can be done about the version in another PR. Might be able to use the "attr" feature of pyproject.toml once all the metadata is over there.

rasbt commented 9 months ago

Arg, yes, dependency management is the most frustrating part about CI setups. It seems to be a new compatibility issue (probably unrelated with the changes in your PR) with the pinned NumPy and Pandas versions. It's weird as it worked fine before.