search

rasbt / mlxtend

A library of extension and helper modules for Python's data analysis and machine learning libraries.
https://rasbt.github.io/mlxtend/
Other
4.82k stars 853 forks source link

ci fix #1066

Closed rasbt closed 9 months ago

jmahlik commented 9 months ago

I wonder if making a fresh new conda environment might be an alternative to updating the base?

Or pip installing the development requirements in base from a testing extra? Like python -m pip install .[testing]? Then you might not have to mess with conda updates at all.

rasbt commented 9 months ago

Yeah, I actually intermittently tried pip but then it had some issues with Cython. I wanted to just get it to work again like it used to -- it worked a few months ago. It's really frustrating to not have direct access to the machine and to try it one commit at a time 😅

jmahlik commented 9 months ago

Willing to take a look/help out. I do ci stuff a lot at work.

rasbt commented 9 months ago

Thanks, I think the problem is that we are using old package versions. And there seems to be some incompatibility with the latest Ubuntu version and and old glib version that is required here.

In an ideal world, this could be fixed by updating the unit tests to use the latest packages for pandas etc. But this would require other work in the frequent pattern submodules, which I am saving for a rainy day in the future.

It's tricky. Let's see if this older Ubuntu version works first and go from there 😅

codecov[bot] commented 9 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (68d4d39) 77.26% compared to head (a584bb2) 77.26%. Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1066 +/- ## ======================================= Coverage 77.26% 77.26% ======================================= Files 200 200 Lines 11297 11297 Branches 1483 1513 +30 ======================================= Hits 8729 8729 Misses 2350 2350 Partials 218 218 ``` | [Files Changed](https://app.codecov.io/gh/rasbt/mlxtend/pull/1066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka) | Coverage Δ | | |---|---|---| | [mlxtend/\_base/\_base\_model.py](https://app.codecov.io/gh/rasbt/mlxtend/pull/1066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9fYmFzZS9fYmFzZV9tb2RlbC5weQ==) | `50.00% <ø> (ø)` | | | [mlxtend/\_base/\_classifier.py](https://app.codecov.io/gh/rasbt/mlxtend/pull/1066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9fYmFzZS9fY2xhc3NpZmllci5weQ==) | `94.11% <ø> (ø)` | | | [mlxtend/\_base/\_cluster.py](https://app.codecov.io/gh/rasbt/mlxtend/pull/1066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9fYmFzZS9fY2x1c3Rlci5weQ==) | `89.47% <ø> (ø)` | | | [mlxtend/\_base/\_iterative\_model.py](https://app.codecov.io/gh/rasbt/mlxtend/pull/1066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9fYmFzZS9faXRlcmF0aXZlX21vZGVsLnB5) | `91.07% <ø> (ø)` | | | [mlxtend/\_base/\_multiclass.py](https://app.codecov.io/gh/rasbt/mlxtend/pull/1066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9fYmFzZS9fbXVsdGljbGFzcy5weQ==) | `100.00% <ø> (ø)` | | | [mlxtend/\_base/\_multilayer.py](https://app.codecov.io/gh/rasbt/mlxtend/pull/1066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9fYmFzZS9fbXVsdGlsYXllci5weQ==) | `100.00% <ø> (ø)` | | | [mlxtend/\_base/\_regressor.py](https://app.codecov.io/gh/rasbt/mlxtend/pull/1066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sebastian+Raschka#diff-bWx4dGVuZC9fYmFzZS9fcmVncmVzc29yLnB5) | `91.30% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rasbt commented 9 months ago

It seemed to be a Cython issue that was fixed 🎉 by bumping the sklearn version @jmahlik