search

rasbt / mlxtend

A library of extension and helper modules for Python's data analysis and machine learning libraries.
https://rasbt.github.io/mlxtend/
Other
4.91k stars 869 forks source link

Loess Regression #464

Open jcvall opened 6 years ago

jcvall commented 6 years ago

Suggestion to add loess regression to MLXtend? Thoughts?

Sent with GitHawk

rasbt commented 6 years ago

I think adding this would be super nice. My students were actually asking me about other instance-based learning method but I didn't have a nice implementation of LOESS handy. I think roughly it should use a scikit-learn-like API, so that other methods on top of it (like cross-validation and grid search) can be used conveniently.

Maybe https://github.com/rasbt/mlxtend/blob/master/mlxtend/regressor/linear_regression.py can be used as a template?!

I guess for a first implementation, also let's not worry about KD-trees for data storage and retrieval

Later, this can maybe be refactored into a LocalRegression class as a parent for both LOESS and LOWESS.

What do you think?

Olamyy commented 6 years ago

Hi @rasbt , Can I take this up?

jcvall commented 5 years ago

Great! Olamyy, I say give it a go. Unless there are any objections? I use Loess in R but would like to use it more in Python.

Sent with GitHawk

rasbt commented 5 years ago

Either of you implementing it would be totally fine with me :)