should dlib scikit-image be listed in requirements.txt?

rasbt / mlxtend

A library of extension and helper modules for Python's data analysis and machine learning libraries.

https://rasbt.github.io/mlxtend/

Other

4.9k stars 867 forks source link

should dlib scikit-image be listed in requirements.txt? #724

Closed suliuzh closed 3 years ago

suliuzh commented 4 years ago

Describe the documentation issue

Hi some dependencies such as dlib are listed in .travis.yml. But it is used in source code files like this in the following. If it is a must, I am wondering if such dependencies should be listed in setup.py or requirements.txt?

Suggest a potential improvement or addition

rasbt commented 4 years ago

Good point. dlib is only required for some of the mlxtend.image functions. However, dlib installation causes problems on some computers, and only a very, very small number of people are using the dlib-dependent functions of mlxtend in mlxtend.image, so I didn't want to make it a requirement in setup.py.